lkml.org 
[lkml]   [2022]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC 1/3] dt-bindings: iommu: Add bindings for samsung,sysmmu-v8
From
On 20/01/2022 21:19, Sam Protsenko wrote:
> Only example of usage and header for now.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> .../bindings/iommu/samsung,sysmmu-v8.txt | 31 +++++++++++++

Please, don't copy paste bindings or entire drviers from vendor kernel.
It looks very bad. Instead, submit them in dtschema.

NAK.

> include/dt-bindings/soc/samsung,sysmmu-v8.h | 43 +++++++++++++++++++
> 2 files changed, 74 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iommu/samsung,sysmmu-v8.txt
> create mode 100644 include/dt-bindings/soc/samsung,sysmmu-v8.h
>
> diff --git a/Documentation/devicetree/bindings/iommu/samsung,sysmmu-v8.txt b/Documentation/devicetree/bindings/iommu/samsung,sysmmu-v8.txt
> new file mode 100644
> index 000000000000..d6004ea4a746
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iommu/samsung,sysmmu-v8.txt
> @@ -0,0 +1,31 @@
> +Example (Exynos850, IOMMU for DPU usage):
> +
> + #include <dt-bindings/soc/samsung,sysmmu-v8.h>
> +
> + /* IOMMU group info */
> + iommu_group_dpu: iommu_group_dpu {
> + compatible = "samsung,sysmmu-group";
> + };
> +
> + sysmmu_dpu: sysmmu@130c0000 {
> + compatible = "samsung,sysmmu-v8";
> + reg = <0x130c0000 0x9000>;
> + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>;
> + qos = <15>;
> +
> + clocks = <&cmu_dpu CLK_GOUT_DPU_SMMU_CLK>;
> + clock-names = "gate";
> +
> + sysmmu,secure-irq;
> + sysmmu,secure_base = <0x130d0000>;
> + sysmmu,default_tlb = <TLB_CFG(BL1, PREFETCH_PREDICTION)>;
> + sysmmu,tlb_property =
> + <1 TLB_CFG(BL1, PREFETCH_PREDICTION) (DIR_READ | (1 << 16)) SYSMMU_ID_MASK(0x2, 0xF)>,
> + <2 TLB_CFG(BL1, PREFETCH_PREDICTION) (DIR_READ | (1 << 16)) SYSMMU_ID_MASK(0x4, 0xF)>,
> + <3 TLB_CFG(BL1, PREFETCH_PREDICTION) (DIR_READ | (1 << 16)) SYSMMU_ID_MASK(0x6, 0xF)>,
> + <4 TLB_CFG(BL1, PREFETCH_PREDICTION) (DIR_READ | (1 << 16)) SYSMMU_ID_MASK(0x8, 0xF)>;
> + port-name = "DPU";
> + #iommu-cells = <0>;
> + //power-domains = <&pd_dpu>;

We try not to store dead code in kernel.



Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-01-21 09:26    [W:0.078 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site