Messages in this thread | | | Date | Thu, 20 Jan 2022 15:23:36 -0800 | From | Kees Cook <> | Subject | Re: [PATCH][next] USB: serial: ti_usb_3410_5052: Use struct_size() helper in ti_write_byte() |
| |
On Thu, Jan 20, 2022 at 03:31:31PM -0600, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version, > in order to avoid any potential type mistakes or integer overflows that, > in the worst scenario, could lead to heap overflows. > > Also, address the following sparse warnings: > drivers/usb/serial/ti_usb_3410_5052.c:1521:16: warning: using sizeof on a flexible structure > > Link: https://github.com/KSPP/linux/issues/174 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Looks good.
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |