Messages in this thread | | | Date | Thu, 20 Jan 2022 10:56:50 -0800 (PST) | Subject | Re: [PATCH] arch/riscv/kernel: remove redundant err variable | From | Palmer Dabbelt <> |
| |
On Wed, 12 Jan 2022 00:27:29 PST (-0800), cgel.zte@gmail.com wrote: > From: Minghao Chi <chi.minghao@zte.com.cn> > > Return value from user_regset_copyin() directly instead > of taking this in another redundant variable. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> > Signed-off-by: CGEL ZTE <cgel.zte@gmail.com> > --- > arch/riscv/kernel/ptrace.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c > index 9c0511119bad..a89243730153 100644 > --- a/arch/riscv/kernel/ptrace.c > +++ b/arch/riscv/kernel/ptrace.c > @@ -42,12 +42,10 @@ static int riscv_gpr_set(struct task_struct *target, > unsigned int pos, unsigned int count, > const void *kbuf, const void __user *ubuf) > { > - int ret; > struct pt_regs *regs; > > regs = task_pt_regs(target); > - ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, regs, 0, -1); > - return ret; > + return user_regset_copyin(&pos, &count, &kbuf, &ubuf, regs, 0, -1); > } > > #ifdef CONFIG_FPU
Thanks, this is on for-next.
| |