lkml.org 
[lkml]   [2022]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 1/3] riscv: dts: Add dma-channels property in dma node
From
On Sun, 16 Jan 2022 17:35:26 PST (-0800), zong.li@sifive.com wrote:
> Add dma-channels property, then we can determine how many channels there
> by device tree.
>
> Signed-off-by: Zong Li <zong.li@sifive.com>
> ---
> arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 1 +
> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> index c9f6d205d2ba..3c48f2d7a4a4 100644
> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> @@ -188,6 +188,7 @@ dma@3000000 {
> reg = <0x0 0x3000000 0x0 0x8000>;
> interrupt-parent = <&plic>;
> interrupts = <23 24 25 26 27 28 29 30>;
> + dma-channels = <4>;
> #dma-cells = <1>;
> };
>
> diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
> index 0655b5c4201d..2bdfe7f06e4b 100644
> --- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
> +++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
> @@ -171,6 +171,7 @@ dma: dma@3000000 {
> reg = <0x0 0x3000000 0x0 0x8000>;
> interrupt-parent = <&plic0>;
> interrupts = <23 24 25 26 27 28 29 30>;
> + dma-channels = <4>;
> #dma-cells = <1>;
> };
> uart1: serial@10011000 {

I've got some comments in on the bindings, but I'm assuming it's easier
to keep these all together. Happy to take this through the RISC-V tree,
but I'm guessing it'll be easier to take these via dmaengine as there's
a lot more diff there so

Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

Thanks!

\
 
 \ /
  Last update: 2022-01-20 19:52    [W:0.120 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site