lkml.org 
[lkml]   [2022]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 2/3] docs: firmware-guide: ACPI: Add named interrupt doc
On Thu, Jan 20, 2022 at 3:45 PM Akhil R <akhilrajeev@nvidia.com> wrote:
>
> Added details and example for named interrupts in the ACPI table.

Added details and example for --> Add a detailed example of the

...

> + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) {
> + 0x20,

I would think of splitting this to two separate entries in between of
which the GpioInt() resource is provided. It will explicitly show that
you describe the case only for Interrupt(). Something like

Interrupt (...) { 0x20 }
GpioInt(...) { ... }
Interrupt (...) { 0x24 }

But it's up to you.

> + 0x24
> + }

...

> +The driver can call the function - device_irq_get_byname() with the device
> +and interrupt name as arguments to get the corresponding IRQ number.

Needs switch to fwnode as per comment against the previous patch.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-01-20 16:05    [W:0.090 / U:1.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site