lkml.org 
[lkml]   [2022]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 04/16] clk: samsung: fsd: Add initial clock support
Date
Hi Stephen

>-----Original Message-----
>From: Stephen Boyd [mailto:sboyd@kernel.org]
>Sent: Thursday, January 20, 2022 1:45 AM
>To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm-
>kernel@lists.infradead.org; linux-kernel@vger.kernel.org
>Cc: soc@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org;
>olof@lixom.net; arnd@arndb.de; linus.walleij@linaro.org;
>catalin.marinas@arm.com; robh+dt@kernel.org;
>krzysztof.kozlowski@canonical.com; s.nawrocki@samsung.com; linux-
>samsung-soc@vger.kernel.org; pankaj.dubey@samsung.com; Alim Akhtar
><alim.akhtar@samsung.com>; linux-fsd@tesla.com; Jayati Sahu
><jayati.sahu@samsung.com>; Ajay Kumar <ajaykumar.rs@samsung.com>
>Subject: Re: [PATCH v2 04/16] clk: samsung: fsd: Add initial clock support
>
>Quoting Alim Akhtar (2022-01-18 06:48:39)
>> diff --git a/drivers/clk/samsung/clk-fsd.c
>> b/drivers/clk/samsung/clk-fsd.c new file mode 100644 index
>> 000000000000..2669396d81b9
>> --- /dev/null
>> +++ b/drivers/clk/samsung/clk-fsd.c
>> @@ -0,0 +1,308 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright (c) 2017-2022 Samsung Electronics Co., Ltd.
>> + * https://www.samsung.com
>> + * Copyright (c) 2017-2022 Tesla, Inc.
>> + * https://www.tesla.com
>> + *
>> + * Common Clock Framework support for FSD SoC.
>> + */
>> +
>> +#include <linux/clk-provider.h>
>> +#include <linux/of.h>
>
>include init.h for __initconst and kernel.h for ARRAY_SIZE
>
I did not face any compilation error.
Do I need to explicitly add these header files in driver? I see clk.h implicitly includes kernel.h
Same is the case of other driver in this directory.

>> +
>> +#include <dt-bindings/clock/fsd-clk.h>
>> +
>> +#include "clk.h"
>> +

\
 
 \ /
  Last update: 2022-01-20 14:54    [W:0.272 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site