Messages in this thread | | | From | Guo Ren <> | Date | Thu, 20 Jan 2022 21:43:03 +0800 | Subject | Re: [PATCH V3 15/17] riscv: compat: Add UXL_32 support in start_thread |
| |
On Thu, Jan 20, 2022 at 9:39 PM Arnd Bergmann <arnd@arndb.de> wrote: > > On Thu, Jan 20, 2022 at 8:39 AM <guoren@kernel.org> wrote: > > + > > +#ifdef CONFIG_COMPAT > > + if (is_compat_task()) > > + regs->status |= SR_UXL_32; > > +#endif > > > You should not need that #ifdef, as the is_compat_task() definition is > meant to drop the code at compile time, unless the SR_UXL_32 > definition is not visible here. I almost put CONFIG_COMPAT in every compat related code, because I hope the next arch that wants to support COMPAT could easily find where to be modified.
> > Arnd
-- Best Regards Guo Ren
ML: https://lore.kernel.org/linux-csky/
| |