Messages in this thread | | | Date | Thu, 20 Jan 2022 13:27:42 +0000 | From | Matthew Wilcox <> | Subject | Re: [PATCH 1/5] mm: remove page_is_file_lru function |
| |
On Thu, Jan 20, 2022 at 09:10:20PM +0800, alexs@kernel.org wrote: > From: Alex Shi <alexs@kernel.org> > > This function could be full replaced by folio_is_file_lru, so no reason > to keep a duplicate function.
This is not a helpful way to do this kind of replacement.
Instead of choosing a function to remove and doing a blind replacement, choose a call site and convert the whole calling function to use folios. Once you've removed all callers, you can remove the wrapper function.
Also, a number of changes here will conflict with patches I've already posted. Try doing change_pte_range() in mprotect.c to get a feel for how to convert a function entirely to folios.
| |