Messages in this thread | | | Date | Thu, 20 Jan 2022 11:45:36 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH 0/3] lib/string_helpers: Add a few string helpers |
| |
On Thu 2022-01-20 11:12:27, Jani Nikula wrote: > On Thu, 20 Jan 2022, Petr Mladek <pmladek@suse.com> wrote: > > The problem is not that visible with yesno() and onoff(). But as you said, > > onoff() confliscts with variable names. And enabledisable() sucks. > > As a result, there is a non-trivial risk of two mass changes: > > My point is, in the past three years we could have churned through more > than two mass renames just fine, if needed, *if* we had just managed to > merge something for a start!
Huh, this sound alarming.
Cosmetic changes just complicate history. They make "git blame" useless. They also complicate backports. I know that it is not problem for mainline. But there are supported stable branches, ...
There should be a good reason for such changes. They should not be done light-heartedly.
Best Regards, Petr
| |