Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 20 Jan 2022 10:36:13 +0100 | Subject | Re: [PATCH V3 10/17] riscv: compat: Add elf.h implementation |
| |
On Thu, Jan 20, 2022 at 8:39 AM <guoren@kernel.org> wrote: > From: Guo Ren <guoren@linux.alibaba.com> > > Implement necessary type and macro for compat elf. See the code > comment for detail. > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> + > +/* > + * FIXME: not sure SET_PERSONALITY for compat process is right! > + */ > +#define SET_PERSONALITY(ex) \ > +do { if ((ex).e_ident[EI_CLASS] == ELFCLASS32) \ > + set_thread_flag(TIF_32BIT); \ > + else \ > + clear_thread_flag(TIF_32BIT); \ > + if (personality(current->personality) != PER_LINUX32) \ > + set_personality(PER_LINUX | \ > + (current->personality & (~PER_MASK))); \ > +} while (0) > +
The implementation looks good to me now, you can remove that comment above it.
Arnd
| |