lkml.org 
[lkml]   [2022]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 1/2] spi: Add spi driver for Sunplus SP7021
On Thu, Jan 20, 2022 at 11:22 AM Lh Kuo 郭力豪 <lh.Kuo@sunplus.com> wrote:

...

> > > + if (xfer->tx_buf)
> > > + dma_unmap_single(dev, xfer->tx_dma, xfer->len, DMA_TO_DEVICE);
> > > + if (xfer->rx_buf)
> > > + dma_unmap_single(dev, xfer->rx_dma, xfer->len,
> > > + DMA_FROM_DEVICE);
> >
> > Why can't you use SPI core DMA mapping code?
>
> I didn't find the SPI core DMA mapping code for single maping.
> The method currently used is the general DMA single-map code usage method.

Why do you need single page mapping?
What's wrong with SG mapping that SPI core provides?

...

> > > + device_set_node(&ctlr->dev, pdev->dev.fwnode);
> >
> > Use dev_fwnode() in the second argument.
>
> You mean as below ?
>
> device_set_node(&ctlr->dev, dev_fwnode(dev));

Yes.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-01-20 10:53    [W:1.029 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site