Messages in this thread | | | From | Kai-Heng Feng <> | Date | Fri, 21 Jan 2022 12:01:35 +0800 | Subject | Re: [PATCH v2] net: phy: marvell: Honor phy LED set by system firmware on a Dell hardware |
| |
On Thu, Jan 20, 2022 at 10:26 PM Andrew Lunn <andrew@lunn.ch> wrote: > > On Thu, Jan 20, 2022 at 01:19:29PM +0800, Kai-Heng Feng wrote: > > BIOS on Dell Edge Gateway 3200 already makes its own phy LED setting, so > > instead of setting another value, keep it untouched and restore the saved > > value on system resume. > > > > Introduce config_led() callback in phy_driver() to make the implemtation > > generic. > > I'm also wondering if we need to take a step back here and get the > ACPI guys involved. I don't know much about ACPI, but shouldn't it > provide a control method to configure the PHYs LEDs? > > We already have the basics for defining a PHY in ACPI. See: > > https://www.kernel.org/doc/html/latest/firmware-guide/acpi/dsd/phy.html
These properties seem to come from device-tree.
> > so you could extend this to include a method to configure the LEDs for > a specific PHY.
How to add new properties? Is it required to add new properties to both DT and ACPI? Looks like many drivers use _DSD freely, but those properties are not defined in ACPI spec...
Kai-Heng
> > Andrew
| |