Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Thu, 20 Jan 2022 09:07:10 +0100 | Subject | Re: [PATCH -next 1/2] gpio: idt3243x: Fix an ignored error return from platform_get_irq() |
| |
On Wed, Jan 19, 2022 at 2:04 AM Yang Li <yang.lee@linux.alibaba.com> wrote: > > The return from the call to platform_get_irq() is int, it can be > a negative error code, however this is being assigned to an unsigned > int variable 'parent_irq', so making 'parent_irq' an int. > > Eliminate the following coccicheck warning: > ./drivers/gpio/gpio-idt3243x.c:167:6-16: WARNING: Unsigned expression > compared with zero: parent_irq < 0 > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Fixes: 30fee1d7462a ("gpio: idt3243x: Fix IRQ check in idt_gpio_probe") > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/gpio/gpio-idt3243x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-idt3243x.c b/drivers/gpio/gpio-idt3243x.c > index 08493b05be2d..52b8b72ded77 100644 > --- a/drivers/gpio/gpio-idt3243x.c > +++ b/drivers/gpio/gpio-idt3243x.c > @@ -132,7 +132,7 @@ static int idt_gpio_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct gpio_irq_chip *girq; > struct idt_gpio_ctrl *ctrl; > - unsigned int parent_irq; > + int parent_irq; > int ngpios; > int ret; > > -- > 2.20.1.7.g153144c >
Queued for fixes, thanks!
Bart
| |