lkml.org 
[lkml]   [2022]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] drm/msm/dsi: Fix missing put_device() call in dsi_get_phy
From
On 30/12/2021 10:09, Miaoqian Lin wrote:
> If of_find_device_by_node() succeeds, dsi_get_phy() doesn't
> a corresponding put_device(). Thus add put_device() to fix the exception
> handling.
>
> Fixes: ec31abf ("drm/msm/dsi: Separate PHY to another platform device")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---
> drivers/gpu/drm/msm/dsi/dsi.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c
> index 75ae3008b68f..35be526e907a 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi.c
> @@ -40,7 +40,12 @@ static int dsi_get_phy(struct msm_dsi *msm_dsi)
>
> of_node_put(phy_node);
>
> - if (!phy_pdev || !msm_dsi->phy) {
> + if (!phy_pdev) {
> + DRM_DEV_ERROR(&pdev->dev, "%s: phy driver is not ready\n", __func__);
> + return -EPROBE_DEFER;
> + }
> + if (!msm_dsi->phy) {
> + put_device(&phy_pdev->dev);
> DRM_DEV_ERROR(&pdev->dev, "%s: phy driver is not ready\n", __func__);
> return -EPROBE_DEFER;
> }


--
With best wishes
Dmitry

\
 
 \ /
  Last update: 2022-01-20 00:17    [W:0.041 / U:0.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site