Messages in this thread | | | Date | Wed, 19 Jan 2022 20:36:55 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH] driver core: platform: Rename platform_get_irq_optional() to platform_get_irq_silent() |
| |
On Sat, Jan 15, 2022 at 02:55:50PM +0100, Uwe Kleine-König wrote: > On Fri, Jan 14, 2022 at 08:55:07PM +0300, Sergey Shtylyov wrote: > > On 1/14/22 12:42 AM, Florian Fainelli wrote:
> So you oppose to the name chosen, but not the renaming as such.
I oppose the name change. The unneeded churn right now since it won't fix the issues with the underneath API (platform_get_irq() in this case) and will require one more iteration over callers again.
The main issue that platform_get_irq*() returns magic error code while treating 0 in a very special way (issuing WARN() and considering it as a successful cookie) and this all is quite confusing.
If you are going to fix the underlying issue, welcome! Now I see only the step to somewhere. I.o.w. this change _standalone_ makes no sense to me.
-- With Best Regards, Andy Shevchenko
| |