Messages in this thread Patch in this message | | | From | Hugo Villeneuve <> | Date | Wed, 19 Jan 2022 12:27:39 -0500 | Subject | [PATCH] rtc: pcf2127: add error message if writing to CLKOUT register fails |
| |
From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
If writing to CLKOUT register fails, the probe operation will be aborted without a meaningful error message.
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> --- drivers/rtc/rtc-pcf2127.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c index 3d1f57e54372..823abe2a7147 100644 --- a/drivers/rtc/rtc-pcf2127.c +++ b/drivers/rtc/rtc-pcf2127.c @@ -717,8 +717,10 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap, if (!(val & PCF2127_BIT_CLKOUT_OTPR)) { ret = regmap_set_bits(pcf2127->regmap, PCF2127_REG_CLKOUT, PCF2127_BIT_CLKOUT_OTPR); - if (ret < 0) + if (ret < 0) { + dev_err(dev, "writing to CLKOUT register failed\n"); return ret; + } msleep(100); } -- 2.30.2
| |