Messages in this thread | | | Date | Wed, 19 Jan 2022 10:06:35 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation |
| |
On Wed, 19 Jan 2022 11:18:59 +0200 Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
> On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head, > > case 3: > > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO) > > tomoyo_io_printf(head, " grant_log=%s", > > - tomoyo_yesno(cond->grant_log == > > - TOMOYO_GRANTLOG_YES)); > > + yesno(cond->grant_log == TOMOYO_GRANTLOG_YES)); > > This would be better split on two lines.
Really? Yuck!
I thought the "max line size" guideline was going to grow to a 100, but I still see it as 80. But anyway...
cond->grant_log == TOMOYO_GRANTLOG_YES
is not readable at all. Not compared to
cond->grant_log == TOMOYO_GRANTLOG_YES
I say keep it one line!
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
> > Then, > > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
| |