| Date | Wed, 19 Jan 2022 13:55:43 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v8 31/40] x86/compressed: add SEV-SNP feature detection/setup |
| |
On Fri, Dec 10, 2021 at 09:43:23AM -0600, Brijesh Singh wrote: > +/* > + * TODO: These are exported only temporarily while boot/compressed/sev.c is > + * the only user. This is to avoid unused function warnings for kernel/sev.c > + * during the build of kernel proper. > + * > + * Once the code is added to consume these in kernel proper these functions > + * can be moved back to being statically-scoped to units that pull in > + * sev-shared.c via #include and these declarations can be dropped. > + */ > +struct cc_blob_sev_info *snp_find_cc_blob_setup_data(struct boot_params *bp);
You don't need any of that - just add the function with the patch which uses it.
> +/* > + * Search for a Confidential Computing blob passed in as a setup_data entry > + * via the Linux Boot Protocol. > + */ > +struct cc_blob_sev_info * > +snp_find_cc_blob_setup_data(struct boot_params *bp)
Please break lines like that only if absolutely necessary. Which doesn't look like it here.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
|