lkml.org 
[lkml]   [2022]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v12 2/5] arm64: zynqmp: DT: Add Xilinx AMS node
    On Fri, 03 Dec 2021 21:23:55 +0000, Anand Ashok Dumbre wrote:
    > The Xilinx AMS includes an ADC as well as on-chip sensors that can be
    > used to sample external and monitor on-die operating conditions, such as
    > temperature and supply voltage levels.
    >
    > Co-developed-by: Manish Narani <manish.narani@xilinx.com>
    > Signed-off-by: Manish Narani <manish.narani@xilinx.com>
    > Signed-off-by: Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
    > ---
    > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 24 ++++++++++++++++++++++++
    > 1 file changed, 24 insertions(+)
    >
    > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
    > index 74e66443e4ce..ab96708fe65e 100644
    > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
    > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
    > @@ -878,6 +878,30 @@
    > timeout-sec = <10>;
    > };
    >
    > + xilinx_ams: ams@ffa50000 {
    > + compatible = "xlnx,zynqmp-ams";
    > + status = "disabled";
    > + interrupt-parent = <&gic>;
    > + interrupts = <0 56 4>;
    > + reg = <0x0 0xffa50000 0x0 0x800>;
    > + #address-cells = <1>;
    > + #size-cells = <1>;
    > + #io-channel-cells = <1>;
    > + ranges = <0 0 0xffa50800 0x800>;
    > +
    > + ams_ps: ams-ps@0 {
    > + compatible = "xlnx,zynqmp-ams-ps";
    > + status = "disabled";
    > + reg = <0 0x400>;
    > + };
    > +
    > + ams_pl: ams-pl@400 {
    > + compatible = "xlnx,zynqmp-ams-pl";
    > + status = "disabled";
    > + reg = <0x400 0x400>;
    > + };
    > + };
    > +

    The patch should also add the xilinx_ams node to
    arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi as:

    &xilinx_ams {
    clocks = <&zynqmp_clk AMS_REF>;
    };

    Otherwise the driver fails to find the clock during probe.

    Michael

    > zynqmp_dpdma: dma-controller@fd4c0000 {
    > compatible = "xlnx,zynqmp-dpdma";
    > status = "disabled";
    > --
    > 2.17.1
    \
     
     \ /
      Last update: 2022-01-19 12:51    [W:2.540 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site