Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 19 Jan 2022 13:40:20 +0200 | Subject | Re: [PATCH v3 1/4] Watchdog: sp5100_tco: Move timer initialization into function |
| |
On Tue, Jan 18, 2022 at 10:22 PM Terry Bowman <terry.bowman@amd.com> wrote: > > Refactor driver's timer initialization into new function. This is needed > inorder to support adding new device layouts while using common timer > initialization.
> Co-developed-by: Robert Richter <rrichter@amd.com> > Signed-off-by: Robert Richter <rrichter@amd.com> > Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> To: Guenter Roeck <linux@roeck-us.net> > To: linux-watchdog@vger.kernel.org > To: Jean Delvare <jdelvare@suse.com> > To: linux-i2c@vger.kernel.org > To: Wolfram Sang <wsa@kernel.org> > To: Andy Shevchenko <andy.shevchenko@gmail.com> > To: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Cc: linux-kernel@vger.kernel.org > Cc: Wim Van Sebroeck <wim@linux-watchdog.org> > Cc: Robert Richter <rrichter@amd.com> > Cc: Thomas Lendacky <thomas.lendacky@amd.com>
Please, do not pollute commit messages with this rather unnecessary list of recipients. There are (at least?) two possibilities: - use --cc and --to whe run `git send-email` - move them under the cutter '--- ' line below
> ---
> + val = readl(SP5100_WDT_CONTROL(tco->tcobase)); > + if (val & SP5100_WDT_DISABLED) { > + dev_err(dev, "Watchdog hardware is disabled\n"); > + return(-ENODEV);
Missed space, too many parentheses.
> + }
-- With Best Regards, Andy Shevchenko
| |