lkml.org 
[lkml]   [2022]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] cpuset: Fix the bug that subpart_cpus updated wrongly in update_cpumask()
From
On 1/18/22 05:05, Tianchen Ding wrote:
> subparts_cpus should be limited as a subset of cpus_allowed, but it is
> updated wrongly by using cpumask_andnot(). Use cpumask_and() instead to
> fix it.
>
> Fixes: ee8dde0cd2ce ("cpuset: Add new v2 cpuset.sched.partition flag")
> Signed-off-by: Tianchen Ding <dtcccc@linux.alibaba.com>
> ---
> kernel/cgroup/cpuset.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index bb3531e7fda7..804ff5738c5f 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -1635,8 +1635,7 @@ static int update_cpumask(struct cpuset *cs, struct cpuset *trialcs,
> * Make sure that subparts_cpus is a subset of cpus_allowed.
> */
> if (cs->nr_subparts_cpus) {
> - cpumask_andnot(cs->subparts_cpus, cs->subparts_cpus,
> - cs->cpus_allowed);
> + cpumask_and(cs->subparts_cpus, cs->subparts_cpus, cs->cpus_allowed);
> cs->nr_subparts_cpus = cpumask_weight(cs->subparts_cpus);
> }
> spin_unlock_irq(&callback_lock);

Thanks for the fix.

Reviewed-by: Waiman Long <longman@redhat.com>

\
 
 \ /
  Last update: 2022-01-18 21:23    [W:0.062 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site