lkml.org 
[lkml]   [2022]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/3] x86/sev: The code for returning to user space is also in syscall gap
    From


    On 2022/1/18 18:32, Borislav Petkov wrote:
    > On Fri, Dec 17, 2021 at 12:00:34PM +0100, Joerg Roedel wrote:
    >> On Fri, Dec 17, 2021 at 11:30:10AM +0100, Borislav Petkov wrote:
    >>> I audited the handful instructions in there and didn't find anything
    >>> that would cause a #VC...
    >>
    >> If the hypervisor decides to mess with the code-page for this path
    >> while a CPU is executing it. This will cause a #VC on that CPU and that
    >> could hit in the syscall return path.
    >
    > So I added a CPUID on that return path:
    >
    > @@ -213,8 +213,11 @@ syscall_return_via_sysret:
    >
    > popq %rdi
    > popq %rsp
    > + cpuid
    >
    >
    > It results in the splat below. I.e., we're on the VC2 stack. We've
    > landed there because:
    >
    > * If entered from kernel-mode the return stack is validated first, and if it is
    > * not safe to use (e.g. because it points to the entry stack) the #VC handler
    > * will switch to a fall-back stack (VC2) and call a special handler function.
    >

    Hello

    Thanks for testing.

    The log shows that the %rsp is 0x7ffc79fd7e78 before the #VC, which means the
    userspace might not be malicious since it might not tamper the %rsp.

    If the userspace is not malicious, there is nothing wrong with it when #VC is
    on this gap.

    If the userspace is malicious and misleads vc_switch_off_ist(), it would harm
    the system.

    For example, (I haven't test it, I am just imaging it,) if user %rsp were set
    to be the kernel #NMI stack, #VC would keep running on #NMI stack, its stack
    would be corrupted when a #NMI is delivered since #NMI is not masked. It would
    be more dangerous if the hypervisor connives with the userspace.

    I think ip_within_syscall_gap() was designed for avoid using userspace %rsp
    albeit it misses the path returning to user space.

    Thanks
    Lai.

    > and what puts us there is, I think:
    >
    > vc_switch_off_ist:
    > if (!get_stack_info_noinstr(stack, current, &info) || info.type == STACK_TYPE_ENTRY ||
    > info.type > STACK_TYPE_EXCEPTION_LAST)
    > sp = __this_cpu_ist_top_va(VC2);
    >
    > but I need to stare at this more later to figure it all out properly.
    >
    > [ 1.372783] Kernel panic - not syncing: Can't handle #VC exception from unsupported context: sp: 0xfffffe0000019f58, prev_sp: 0x7ffc79fd7e78, VC2 stack [0xfffffe0000018000:0xfffffe000001a000]
    > [ 1.374828] CPU: 0 PID: 1 Comm: init Not tainted 5.16.0+ #6
    > [ 1.375586] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015
    > [ 1.376553] Call Trace:
    > [ 1.377030] <#VC2>
    > [ 1.377462] dump_stack_lvl+0x48/0x5e
    > [ 1.378038] panic+0xfa/0x2c6
    > [ 1.378570] kernel_exc_vmm_communication+0x10e/0x160
    > [ 1.379275] asm_exc_vmm_communication+0x30/0x60
    > [ 1.379934] RIP: 0010:syscall_return_via_sysret+0x28/0x2a
    > [ 1.380669] Code: 00 00 41 5f 41 5e 41 5d 41 5c 5d 5b 5e 41 5a 41 59 41 58 58 5e 5a 5e 48 89 e7 65 48 8b 24 25 04 60 00 00 ff 77 28 ff 37 5f 5c <0f> a2 0f 01 f8 48 0f 07 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00
    > [ 1.384240] RSP: 0018:00007ffc79fd7e78 EFLAGS: 00010046
    > [ 1.384977] RAX: 00005555e4b80000 RBX: 0000000000000001 RCX: 00007fc2d978ac17
    > [ 1.385894] RDX: 0000000000000054 RSI: 00007fc2d9792e09 RDI: 0000000000000000
    > [ 1.386816] RBP: 00007fc2d97724e0 R08: 00007ffc79fd9fe7 R09: 00007fc2d979ae88
    > [ 1.387734] R10: 000000000000001c R11: 0000000000000246 R12: 00005555e448e040
    > [ 1.388647] R13: 000000000000000b R14: 0000000000000000 R15: 00007ffc79fd8119
    > [ 1.389559] </#VC2>
    > [ 1.391521] Kernel Offset: 0x7e00000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)
    > [ 1.393015] ---[ end Kernel panic - not syncing: Can't handle #VC exception from unsupported context: sp: 0xfffffe0000019f58, prev_sp: 0x7ffc79fd7e78, VC2 stack [0xfffffe0000018000:0xfffffe000001a000] ]---
    >
    >

    \
     
     \ /
      Last update: 2022-01-18 16:38    [W:4.497 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site