Messages in this thread | | | Date | Tue, 18 Jan 2022 18:07:28 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: r8188eu: handle rtw_init_netdev_name() failure appropriately |
| |
On Mon, Jan 17, 2022 at 12:56:11AM +0530, Vihas Mak wrote: > rtw_init_netdev_name() calls dev_alloc_name() which allocates the name > for the device as per the given name format. > It returns a negative err code if the format is invalid. Currently the > name format is specified by the module parameter "ifname". > Warn the user if "ifname" is invalid. > > Signed-off-by: Vihas Mak <makvihas@gmail.com> > ---
This doesn't really fix the bug. Better to re-write the error handling. See my error handling guide here:
https://lore.kernel.org/all/20210831084735.GL12231@kadam/
regards, dan carpenter
| |