lkml.org 
[lkml]   [2022]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ath9k_htc: fix uninit value bugs
From
Hi Kalle,

On 1/17/22 15:57, Kalle Valo wrote:
>> Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
>> Reported-by: syzbot+f83a1df1ed4f67e8d8ad@syzkaller.appspotmail.com
>> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
>
> How did you test this? As syzbot is mentioned I assume you did not test this on
> a real device, it would help a lot if this is clearly mentioned in the commit
> log. My trust on syzbot fixes is close to zero due to bad past history.
>

You are right, I've tested only with syzbot's reproducer. I've followed
simple guess: if code works properly with random values in these fields
for 14+ years, then zeroing them won't hurt much.

I might be missing something, but unfortunately I don't have suitable hw
piece to test the change.




With regards,
Pavel Skripkin

\
 
 \ /
  Last update: 2022-01-17 19:36    [W:0.084 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site