Messages in this thread | | | Date | Mon, 17 Jan 2022 10:16:24 -0800 | Subject | Re: [PATCH v17 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received | From | Kuogee Hsieh <> |
| |
On 1/14/2022 5:13 PM, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2022-01-14 16:58:32) >> @@ -1363,14 +1368,14 @@ static int dp_pm_suspend(struct device *dev) >> if (dp_power_clk_status(dp->power, DP_CTRL_PM)) >> dp_ctrl_off_link_stream(dp->ctrl); >> >> + dp_display_host_phy_exit(dp); >> + >> + /* host_init will be called at pm_resume */ >> dp_display_host_deinit(dp); >> } > I thought we determined that core_initialized was always true here, so > the if condition is redundant. Furthermore, removing that check allows > us to entirely remove the core_initialized variable from the code.
my mistake. Will remove the condition check.
However, I would like to keep code_initialized for debugging purpose.
Otherwise, we will shot in the dark if customer report bug.
| |