Messages in this thread | | | Subject | Re: [PATCH] perf metric: Fix metric_leader | From | John Garry <> | Date | Mon, 17 Jan 2022 18:04:01 +0000 |
| |
On 15/01/2022 06:28, Ian Rogers wrote: > Multiple events may have a metric_leader to aggregate into. This happens > for uncore events where, for example, uncore_imc is expanded into > uncore_imc_0, uncore_imc_1, etc. Such events all have the same metric_id > and should aggregate into the first event. The change introducing > metric_ids had a bug where the metric_id was compared to itself, > creating an always true condition. Correct this by comparing the > event in the metric_evlist and the metric_leader. > > Fixes: ec5c5b3d2c21 ("perf metric: Encode and use metric-id as qualifier") > Signed-off-by: Ian Rogers<irogers@google.com> > ---
Looks ok and I quickly tested it: Reviewed-by: John Garry <john.garry@huawei.com>
| |