Messages in this thread | | | Date | Mon, 17 Jan 2022 07:03:14 +0100 | Subject | Re: [PATCH] dmaengine: altera-msgdma: Remove useless DMA-32 fallback configuration | From | Stefan Roese <> |
| |
On 1/15/22 08:40, Christophe JAILLET wrote: > As stated in [1], dma_set_mask() with a 64-bit mask never fails if > dev->dma_mask is non-NULL. > So, if it fails, the 32 bits case will also fail for the same reason. > > Simplify code and remove some dead code accordingly. > > [1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks, Stefan
> --- > drivers/dma/altera-msgdma.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c > index f5b885d69cd3..6f56dfd375e3 100644 > --- a/drivers/dma/altera-msgdma.c > +++ b/drivers/dma/altera-msgdma.c > @@ -891,9 +891,7 @@ static int msgdma_probe(struct platform_device *pdev) > ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); > if (ret) { > dev_warn(&pdev->dev, "unable to set coherent mask to 64"); > - ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > - if (ret) > - goto fail; > + goto fail; > } > > msgdma_reset(mdev); >
Viele Grüße, Stefan Roese
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
| |