lkml.org 
[lkml]   [2022]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v2 2/3] staging: pi433: change order in which driver config the rf69 chip
    There is an explicit dependency between modulation and bit rate
    configurations. To ensure proper validation of input value for the
    set_bit_rate routine, we must ensure that modulation has been set
    before.

    This patch ensures that set_modulation is always called before
    set_bit_rate for both RX and TX routines

    Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
    ---
    drivers/staging/pi433/pi433_if.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
    index f9f86e2c44a9..17ff51f6a9da 100644
    --- a/drivers/staging/pi433/pi433_if.c
    +++ b/drivers/staging/pi433/pi433_if.c
    @@ -167,10 +167,10 @@ rf69_set_rx_cfg(struct pi433_device *dev, struct pi433_rx_cfg *rx_cfg)
    ret = rf69_set_frequency(dev->spi, rx_cfg->frequency);
    if (ret < 0)
    return ret;
    - ret = rf69_set_bit_rate(dev->spi, rx_cfg->bit_rate);
    + ret = rf69_set_modulation(dev->spi, rx_cfg->modulation);
    if (ret < 0)
    return ret;
    - ret = rf69_set_modulation(dev->spi, rx_cfg->modulation);
    + ret = rf69_set_bit_rate(dev->spi, rx_cfg->bit_rate);
    if (ret < 0)
    return ret;
    ret = rf69_set_antenna_impedance(dev->spi, rx_cfg->antenna_impedance);
    @@ -290,10 +290,10 @@ rf69_set_tx_cfg(struct pi433_device *dev, struct pi433_tx_cfg *tx_cfg)
    ret = rf69_set_frequency(dev->spi, tx_cfg->frequency);
    if (ret < 0)
    return ret;
    - ret = rf69_set_bit_rate(dev->spi, tx_cfg->bit_rate);
    + ret = rf69_set_modulation(dev->spi, tx_cfg->modulation);
    if (ret < 0)
    return ret;
    - ret = rf69_set_modulation(dev->spi, tx_cfg->modulation);
    + ret = rf69_set_bit_rate(dev->spi, tx_cfg->bit_rate);
    if (ret < 0)
    return ret;
    ret = rf69_set_deviation(dev->spi, tx_cfg->dev_frequency);
    --
    2.25.4
    \
     
     \ /
      Last update: 2022-01-17 07:02    [W:2.197 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site