lkml.org 
[lkml]   [2022]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 20/23] dt-bindings: iio: adc: exynos-adc: Add ADC-V3 variant
Date


>-----Original Message-----
>From: Jonathan Cameron [mailto:Jonathan.Cameron@Huawei.com]
>Sent: Monday, January 17, 2022 3:17 PM
>To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>Cc: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm-
>kernel@lists.infradead.org; linux-kernel@vger.kernel.org; soc@kernel.org;
>linux-clk@vger.kernel.org; devicetree@vger.kernel.org; olof@lixom.net;
>linus.walleij@linaro.org; catalin.marinas@arm.com; robh+dt@kernel.org;
>s.nawrocki@samsung.com; linux-samsung-soc@vger.kernel.org;
>pankaj.dubey@samsung.com; linux-fsd@tesla.com; Tamseel Shams
><m.shams@samsung.com>
>Subject: Re: [PATCH 20/23] dt-bindings: iio: adc: exynos-adc: Add ADC-V3
>variant
>
>On Thu, 13 Jan 2022 14:32:12 +0100
>Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote:
>
>> On 13/01/2022 13:11, Alim Akhtar wrote:
>> > This patch adds a new compatible string for exynos's ADC-V3 variant.
>> >
>> > Cc: linux-fsd@tesla.com
>> > Signed-off-by: Tamseel Shams <m.shams@samsung.com>
>> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>
>Please cc linux-iio@vger.kernel.org for next version...
>
Noted, will separate out these patches from the original series and send.
Thanks

>> > ---
>> > .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git
>> > a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
>> > b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
>> > index 81c87295912c..9303053759ca 100644
>> > ---
>> > a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
>> > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-
>adc.y
>> > +++ aml
>> > @@ -14,6 +14,7 @@ properties:
>> > enum:
>> > - samsung,exynos-adc-v1 # Exynos5250
>> > - samsung,exynos-adc-v2
>> > + - samsung,exynos-adc-v3
>>
>> Please use SoC-specific compatible. IP block versions are tricky because:
>> 1. Documentation/datasheet mentioning which SoC has which block
>> version are not public.
>> 2. Neither are public the datasheets for ADC blocks.
>> 3. The versioning of IP blocks can be inaccurate.
>>
>>
>> Best regards,
>> Krzysztof
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> https://protect2.fireeye.com/v1/url?k=9dd88c77-fca326ff-9dd90738-74fe4
>> 860018a-343cb1b0388f1560&q=1&e=61045889-dd66-417f-b142-
>9e85b39f1676&u=
>> http%3A%2F%2Flists.infradead.org%2Fmailman%2Flistinfo%2Flinux-arm-
>kern
>> el


\
 
 \ /
  Last update: 2022-01-17 13:44    [W:0.088 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site