lkml.org 
[lkml]   [2022]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ath: dfs_pattern_detector: Avoid open coded arithmetic in memory allocation
From
Date
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:

> kmalloc_array()/kcalloc() should be used to avoid potential overflow when
> a multiplication is needed to compute the size of the requested memory.
>
> kmalloc_array() can be used here instead of kcalloc() because the array is
> fully initialized in the next 'for' loop.
>
> Finally, 'cd->detectors' is defined as 'struct pri_detector **detectors;'.
> So 'cd->detectors' and '*cd->detectors' are both some pointer.
> So use a more logical 'sizeof(*cd->detectors)'.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

a063b650ce5d ath: dfs_pattern_detector: Avoid open coded arithmetic in memory allocation

--
https://patchwork.kernel.org/project/linux-wireless/patch/0fbcd32a0384ac1f87c5a3549e505e4becc60226.1640624216.git.christophe.jaillet@wanadoo.fr/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

\
 
 \ /
  Last update: 2022-01-17 13:43    [W:0.035 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site