lkml.org 
[lkml]   [2022]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 29/56] net-sysfs: update the queue counts in the unregistration path
    Date
    From: Antoine Tenart <atenart@kernel.org>

    [ Upstream commit d7dac083414eb5bb99a6d2ed53dc2c1b405224e5 ]

    When updating Rx and Tx queue kobjects, the queue count should always be
    updated to match the queue kobjects count. This was not done in the net
    device unregistration path, fix it. Tracking all queue count updates
    will allow in a following up patch to detect illegal updates.

    Signed-off-by: Antoine Tenart <atenart@kernel.org>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/core/net-sysfs.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
    index 7d8c6ba5cbd22..3a5903f942e18 100644
    --- a/net/core/net-sysfs.c
    +++ b/net/core/net-sysfs.c
    @@ -1449,6 +1449,9 @@ static void remove_queue_kobjects(struct net_device *dev)

    net_rx_queue_update_kobjects(dev, real_rx, 0);
    netdev_queue_update_kobjects(dev, real_tx, 0);
    +
    + dev->real_num_rx_queues = 0;
    + dev->real_num_tx_queues = 0;
    #ifdef CONFIG_SYSFS
    kset_unregister(dev->queues_kset);
    #endif
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-01-18 04:40    [W:4.049 / U:0.468 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site