lkml.org 
[lkml]   [2022]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 01/59] Bluetooth: Fix debugfs entry leak in hci_register_dev()
    Date
    From: Wei Yongjun <weiyongjun1@huawei.com>

    [ Upstream commit 5a4bb6a8e981d3d0d492aa38412ee80b21033177 ]

    Fault injection test report debugfs entry leak as follows:

    debugfs: Directory 'hci0' with parent 'bluetooth' already present!

    When register_pm_notifier() failed in hci_register_dev(), the debugfs
    create by debugfs_create_dir() do not removed in the error handing path.

    Add the remove debugfs code to fix it.

    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/bluetooth/hci_core.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
    index 26acacb2fa95f..a5755e0645439 100644
    --- a/net/bluetooth/hci_core.c
    +++ b/net/bluetooth/hci_core.c
    @@ -3263,6 +3263,7 @@ int hci_register_dev(struct hci_dev *hdev)
    return id;

    err_wqueue:
    + debugfs_remove_recursive(hdev->debugfs);
    destroy_workqueue(hdev->workqueue);
    destroy_workqueue(hdev->req_workqueue);
    err:
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-01-18 04:40    [W:4.524 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site