lkml.org 
[lkml]   [2022]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.15 177/188] serial: pl011: Drop CR register reset on set_termios
    Date
    From: Lukas Wunner <lukas@wunner.de>

    [ Upstream commit e368cc656fd6d0075f1c3ab9676e2001451e3e04 ]

    pl011_set_termios() briefly resets the CR register to zero, thereby
    glitching DTR/RTS signals. With rs485 this may result in the bus being
    occupied for no reason.

    Where does this register write originate from?

    The PL011 driver was forked from the PL010 driver in 2004:
    https://git.kernel.org/history/history/c/157c0342e591

    Until this commit, the PL010 driver's IRQ handler ambauart_int()
    modified the CR register without holding the port spinlock.

    ambauart_set_termios() also modified that register. To prevent
    concurrent read-modify-writes by the IRQ handler and to prevent
    transmission while changing baudrate, ambauart_set_termios() had to
    disable interrupts. On the PL010, that is achieved by writing zero to
    the CR register.

    However, on the PL011, interrupts are disabled in the IMSC register,
    not in the CR register.

    Additionally, the commit amended both the PL010 and PL011 driver to
    acquire the port spinlock in the IRQ handler, obviating the need to
    disable interrupts in ->set_termios().

    So the CR register write is obsolete for two reasons. Drop it.

    Cc: Russell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: Lukas Wunner <lukas@wunner.de>
    Link: https://lore.kernel.org/r/f49f945375f5ccb979893c49f1129f51651ac738.1641129062.git.lukas@wunner.de
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/serial/amba-pl011.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
    index 52518a606c06a..9b1b0d9bdf7be 100644
    --- a/drivers/tty/serial/amba-pl011.c
    +++ b/drivers/tty/serial/amba-pl011.c
    @@ -2105,9 +2105,7 @@ pl011_set_termios(struct uart_port *port, struct ktermios *termios,
    if (port->rs485.flags & SER_RS485_ENABLED)
    termios->c_cflag &= ~CRTSCTS;

    - /* first, disable everything */
    old_cr = pl011_read(uap, REG_CR);
    - pl011_write(0, uap, REG_CR);

    if (termios->c_cflag & CRTSCTS) {
    if (old_cr & UART011_CR_RTS)
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-01-18 04:10    [W:4.157 / U:0.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site