Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Mon, 17 Jan 2022 15:44:37 +0800 | Subject | Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output |
| |
On Sat, Jan 15, 2022 at 7:03 AM Brian Norris <briannorris@chromium.org> wrote: > > Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > switched the platform to SPDIF, but we didn't fix up the device tree. > > Drop the pinctrl settings, because the 'spdif_bus' pins are either: > * unused (on kevin, bob), so the settings is ~harmless > * used by a different function (on scarlet), which causes probe > failures (!!)
I suppose that means the default pinctrl should be dropped? Or maybe this use case is the outlier. Up to Heiko?
> Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
| |