Messages in this thread | | | Date | Sun, 16 Jan 2022 13:54:44 +0100 | Subject | Re: [PATCH] lib/string_helpers: Use the given gfp flag when allocating memory | From | Christophe JAILLET <> |
| |
Le 16/01/2022 à 13:49, Christophe JAILLET a écrit : > kstrdup_quotable_cmdline() is given a gfp flag that is passed and used for > memory allocation in kstrdup_quotable() just a few lines below. > > It looks reasonable to use this gfp value for the buffer allocated and > freed in kstrdup_quotable_cmdline() as well. > > Fixes: 0ee931c4e31a ("mm: treewide: remove GFP_TEMPORARY allocation flag") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > According to what I've found in 5.16, all callers use GFP_KERNEL, so this > patch should be a no-op. > But who knows how it will be used in the future. Better safe than sorry. > --- > lib/string_helpers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/string_helpers.c b/lib/string_helpers.c > index 90f9f1b7afec..7aceeb40dfd7 100644 > --- a/lib/string_helpers.c > +++ b/lib/string_helpers.c > @@ -624,7 +624,7 @@ char *kstrdup_quotable_cmdline(struct task_struct *task, gfp_t gfp) > char *buffer, *quoted; > int i, res; > > - buffer = kmalloc(PAGE_SIZE, GFP_KERNEL); > + buffer = kmalloc(PAGE_SIZE, gfp); > if (!buffer) > return NULL; > >
I have sent a V2. I missed the same issue in kstrdup_quotable_file().
CJ
| |