Messages in this thread | | | From | Linus Walleij <> | Date | Sun, 16 Jan 2022 13:07:34 +0100 | Subject | Re: [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio_probe |
| |
On Fri, Jan 14, 2022 at 7:51 AM Miaoqian Lin <linmq006@gmail.com> wrote:
> platform_get_irq() returns negative error number instead 0 on failure. > And the doc of platform_get_irq() provides a usage example: > > int irq = platform_get_irq(pdev, 0); > if (irq < 0) > return irq; > > Fix the check of return value to catch errors correctly. > > Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |