Messages in this thread | | | Date | Sun, 16 Jan 2022 19:29:46 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] EDAC/dmc520: Don't print an error for each unconfigured interrupt line |
| |
On Tue, Jan 11, 2022 at 10:38:00AM -0600, Tyler Hicks wrote: > The dmc520 driver requires that at least one interrupt line, out of the ten > possible, is configured. The driver prints an error and returns -EINVAL > from its .probe function if there are no interrupt lines configured. > > Don't print a KERN_ERR level message for each interrupt line that's > unconfigured as that can confuse users into thinking that there is an > error condition. > > Before this change, the following KERN_ERR level messages would be > reported if only dram_ecc_errc and dram_ecc_errd were configured in the > device tree: > > dmc520 68000000.dmc: IRQ ram_ecc_errc not found > dmc520 68000000.dmc: IRQ ram_ecc_errd not found > dmc520 68000000.dmc: IRQ failed_access not found > dmc520 68000000.dmc: IRQ failed_prog not found > dmc520 68000000.dmc: IRQ link_err not > dmc520 68000000.dmc: IRQ temperature_event not found > dmc520 68000000.dmc: IRQ arch_fsm not found > dmc520 68000000.dmc: IRQ phy_request not found > > Fixes: 1088750d7839 ("EDAC: Add EDAC driver for DMC520") > Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com> > Cc: <stable@vger.kernel.org>
Why stable? AFAICT, this is fixing only the spew of some error messages but the driver is still functional.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |