Messages in this thread | | | Date | Sun, 16 Jan 2022 15:19:06 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) |
| |
On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-König wrote: > A possible compromise: We can have both. We rename > platform_get_irq_optional() to platform_get_irq_silent() (or > platform_get_irq_silently() if this is preferred) and once all users are > are changed (which can be done mechanically), we reintroduce a > platform_get_irq_optional() with Sergey's suggested semantic (i.e. > return 0 on not-found, no error message printking).
Please do not do that as anyone trying to forward-port an old driver will miss the abi change of functionality and get confused. Make build-breaking changes, if the way a function currently works is changed in order to give people a chance.
thanks,
greg k-h
| |