lkml.org 
[lkml]   [2022]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: frequency: admv1013: remove the always true condition
On Wed, 5 Jan 2022 02:09:20 +0500
Muhammad Usama Anjum <usama.anjum@collabora.com> wrote:

> unsigned int variable is always greater than or equal to zero. Make the
> if condition simple.
>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Hi,

+ CC Antoniu and this should have a Fixes tag.

Thanks,

Jonathan

> ---
> drivers/iio/frequency/admv1013.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1013.c
> index 6cdeb50143af..3f3c478e9baa 100644
> --- a/drivers/iio/frequency/admv1013.c
> +++ b/drivers/iio/frequency/admv1013.c
> @@ -348,7 +348,7 @@ static int admv1013_update_mixer_vgate(struct admv1013_state *st)
>
> vcm = regulator_get_voltage(st->reg);
>
> - if (vcm >= 0 && vcm < 1800000)
> + if (vcm < 1800000)
> mixer_vgate = (2389 * vcm / 1000000 + 8100) / 100;
> else if (vcm > 1800000 && vcm < 2600000)
> mixer_vgate = (2375 * vcm / 1000000 + 125) / 100;

\
 
 \ /
  Last update: 2022-01-15 19:05    [W:0.059 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site