Messages in this thread | | | Date | Sat, 15 Jan 2022 17:50:30 +0100 | Subject | Re: [PATCH v2 11/11] arm64: dts: freescale: add initial support for verdin imx8m mini | From | Krzysztof Kozlowski <> |
| |
On 14/01/2022 15:15, Marcel Ziswiler wrote: > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > This patch adds the device tree to support Toradex Verdin iMX8M Mini a > computer on module which can be used on different carrier boards. > > The module consists of an NXP i.MX 8M Mini family SoC (either i.MX 8M > Mini Quad or 8M Mini DualLite), a PCA9450A PMIC, a Gigabit Ethernet PHY, > 1 or 2 GB of LPDDR4 RAM, an eMMC, a TLA2024 ADC, an I2C EEPROM, an > RX8130 RTC, an optional SPI CAN controller plus an optional Bluetooth/ > Wi-Fi module. > > Anything that is not self-contained on the module is disabled by > default. > > The device tree for the Dahlia includes the module's device tree and > enables the supported peripherals of the carrier board. > > The device tree for the Verdin Development Board includes the module's > device tree as well as the Dahlia one as it is a superset and supports > almost all peripherals available. > > So far there is no display functionality supported at all but basic > console UART, USB host, eMMC and Ethernet and PCIe functionality work > fine. > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > --- > > Changes in v2: > - Remove bootargs which will be filled in by the bootloader as requested > by Krzysztof. > - Remove the previously #ifdefed-out spi-nor as requested by Krzysztof. > - Fix capitalisation in cover-letter. >
Thanks for the changes.
Looks, good but I did not perform review thorough enough to give a Reviewed-by tag, so let it be just:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards, Krzysztof
| |