Messages in this thread | | | Date | Fri, 14 Jan 2022 08:23:08 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH 2/2] stmmac: intel: Honor phy LED set by system firmware on a Dell hardware |
| |
On Fri, 14 Jan 2022 14:47:47 +0800 Kai-Heng Feng wrote: > > Coincidentally the first Marvell flag appears dead, nobody sets it: > > > > $ git grep MARVELL_PHY_M1145_FLAGS_RESISTANCE > > drivers/net/phy/marvell.c: if (phydev->dev_flags & MARVELL_PHY_M1145_FLAGS_RESISTANCE) { > > include/linux/marvell_phy.h:#define MARVELL_PHY_M1145_FLAGS_RESISTANCE 0x00000001 > > $ > > > > unless it's read from DT under different name or something. > > It was introduced by 95d21ff4c645 without any user. Should we keep it?
Not unless someone explains that it's actually used somehow.
Please post a patch once net-next opens.
| |