Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 14 Jan 2022 11:46:04 +0200 | Subject | Re: [PATCH v5 2/2] pinctrl: Add driver for Sunplus SP7021 |
| |
On Fri, Jan 14, 2022 at 4:51 AM Wells Lu 呂芳騰 <wells.lu@sunplus.com> wrote:
...
> > > > > > > + bool "Sunplus SP7021 PinMux and GPIO driver" > > > > > > > > > > > > Why bool and not tristate? > > > > > > > > > > Pinctrl driver is selected by many drivers in SP7021 platform. > > > > > We never build it as a module, but build-in to kernel. > > > > > So we use "bool". > > > > > > > > > > Should we set it to tristate? > > > > > > > > You still haven't answered "why", so I can't tell you. > > > > > > I am puzzled because I think I have answered "why". > > > > Nope. :-) > > > > > Because Pinctrl driver is necessary for all SP7021-based platforms. > > > > "Why?" Why is it necessary (to be built-in)? > > Pinctrl is necessary to be built-in because drivers of boot-device, > like eMMC, SD card, NAND flash, and NOR flash drivers, need it. > > SP7021 supports booting from eMMC, SD card, NAND flash and NOR flash > devices. Their drivers need Pinctrl driver probes in advance.
On x86 platforms, for example, booting from eMMC and SD card does not require a pin control driver to be built-in. Why is this requirement for SP platforms?
-- With Best Regards, Andy Shevchenko
| |