lkml.org 
[lkml]   [2022]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] HID: google: modify HID device groups of eel
    On Fri, 7 Jan 2022, Zhengqiao Xia wrote:

    > If HID_GROUP of eel is set to HID_GROUP_GENERIC, Whiskers Tablet
    > Mode Switch of eel hammer will not be detected by system. when it
    > is set to HID_GROUP_VIVALDI, system will detect Whiskers Tablet
    > Mode Switch successfully.
    >
    > Signed-off-by: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
    > ---
    > drivers/hid/hid-google-hammer.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
    > index 0403beb3104b..e5acd15f4a55 100644
    > --- a/drivers/hid/hid-google-hammer.c
    > +++ b/drivers/hid/hid-google-hammer.c
    > @@ -585,7 +585,7 @@ static void hammer_remove(struct hid_device *hdev)
    > static const struct hid_device_id hammer_devices[] = {
    > { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
    > USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_DON) },
    > - { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
    > + { HID_DEVICE(BUS_USB, HID_GROUP_VIVALDI,
    > USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_EEL) },
    > { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,

    Color me confused, but anything with HID_GROUP_VIVALDI should be matched
    by hid-vivaldi driver, so what is this about?

    Adding some more CCs.

    Thanks,

    --
    Jiri Kosina
    SUSE Labs

    \
     
     \ /
      Last update: 2022-01-14 09:38    [W:3.133 / U:0.540 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site