Messages in this thread | | | Subject | Re: [PATCH v2 0/4] docs: sphinx/kfigure.py: Improve conversion to PDF | From | Akira Yokosawa <> | Date | Sat, 15 Jan 2022 11:16:34 +0900 |
| |
On Fri, 14 Jan 2022 09:45:35 +0100, Mauro Carvalho Chehab wrote: > Em Fri, 7 Jan 2022 22:45:47 +0900 > Akira Yokosawa <akiyks@gmail.com> escreveu: > >> On Wed, 29 Dec 2021 20:42:00 +0900, Akira Yokosawa wrote: >>> This patch set improves conversions of DOT -> PDF and SVG -> PDF >>> for PDF docs. >> >> Gentle ping. >> >> Mauro, any comments? > > Sorry, have been busy those days with not much time to test it, > and I'm not expecting any time to test it on the next couple of > weeks.
Mauro, no need of apologies.
We are in the middle of the v5.17 merge window, and I think of this series as a v5.18 material. Which means it won't be merged into doc-next until v5.17-rc5 or -rc6 (mid March or so), unless Jon thinks otherwise.
I'd like to have your Tested-by: and/or Reviewed-by: tags if you could manage to spare time for testing.
> > The main concern from my last review is that inkscape is too noisy > (well, frankly, textlive is also too noisy).
You mean the harmless warning msgs delegated to kernellog.verbose()? Or the direct redirection to /dev/null as of v1's 3/3?
> If this was solved > on a nice way,
An excerpt of messages from Inkscape is as follows (on Debian bullseye, with "make SPHINXOPTS=-v SPHINXDIRS=doc-guide pdfdocs"):
---------- convert SVG to: {out}/svg_image.pdf Warning msg from inkscape(1) (likely harmless): Unable to init server: Could not connect: Connection refused Failed to get connection ** (inkscape:119): CRITICAL **: 01:58:03.988: dbus_g_proxy_new_for_name: assertion 'connection != NULL' failed
** (inkscape:119): CRITICAL **: 01:58:03.988: dbus_g_proxy_call: assertion 'DBUS_IS_G_PROXY (proxy)' failed
** (inkscape:119): CRITICAL **: 01:58:03.988: dbus_g_connection_register_g_object: assertion 'connection != NULL' failed
** (inkscape:119): WARNING **: 01:58:04.300: Fonts dir '/usr/share/inkscape/fonts' does not exist and will be ignored.
assert best format for: hello.dot convert DOT to: {out}/hello.pdf Warning msg from inkscape(1) (likely harmless): Unable to init server: Could not connect: Connection refused Failed to get connection ** (inkscape:129): CRITICAL **: 01:58:04.454: dbus_g_proxy_new_for_name: assertion 'connection != NULL' failed
** (inkscape:129): CRITICAL **: 01:58:04.454: dbus_g_proxy_call: assertion 'DBUS_IS_G_PROXY (proxy)' failed
** (inkscape:129): CRITICAL **: 01:58:04.454: dbus_g_connection_register_g_object: assertion 'connection != NULL' failed
** (inkscape:129): WARNING **: 01:58:04.628: Fonts dir '/usr/share/inkscape/fonts' does not exist and will be ignored. [...] ----------
On Fedora 35, I don't see any message from Inkscape.
Is this acceptable to you?
> and provided that the output files on both html and > pdf are working fine with those conversions, I don't have any > objections to this series.
This series affects only PDF. My test coverage is not perfect, but I don't expect any regression in "make pdfdocs" or "make htmldocs".
Thanks, Akira
> > Regards, > Mauro > [...]
| |