lkml.org 
[lkml]   [2022]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 01/23] dt-bindings: clock: Document FSD CMU bindings
From
On 13/01/2022 13:11, Alim Akhtar wrote:
> Add dt-schema documentation for Tesla FSD SoC clock controller.
>
> Cc: linux-fsd@tesla.com
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
> .../bindings/clock/tesla,fsd-clock.yaml | 212 ++++++++++++++++++
> 1 file changed, 212 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/tesla,fsd-clock.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/tesla,fsd-clock.yaml b/Documentation/devicetree/bindings/clock/tesla,fsd-clock.yaml
> new file mode 100644
> index 000000000000..58f341e5004d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/tesla,fsd-clock.yaml
> @@ -0,0 +1,212 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/tesla,fsd-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Tesla FSD (Full Self-Driving) SoC clock controller
> +
> +maintainers:
> + - Alim Akhtar <alim.akhtar@samsung.com>
> + - linux-fsd@tesla.com
> +
> +description: |
> + FSD clock controller consist of several clock management unit
> + (CMU), which generates clocks for various inteernal SoC blocks.
> + The root clock comes from external OSC clock (24 MHz).
> +
> + All available clocks are defined as preprocessor macros in
> + 'dt-bindings/clock/fsd-clk.h' header.
> +
> +properties:
> + compatible:
> + enum:
> + - tesla,fsd-clock-cmu
> + - tesla,fsd-clock-imem
> + - tesla,fsd-clock-peric
> + - tesla,fsd-clock-fsys0
> + - tesla,fsd-clock-fsys1
> + - tesla,fsd-clock-mfc
> + - tesla,fsd-clock-cam_csi
> +
> + clocks:
> + minItems: 1
> + maxItems: 6
> +
> + clock-names:
> + minItems: 1
> + maxItems: 6
> +
> + "#clock-cells":
> + const: 1
> +
> + reg:
> + maxItems: 1
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: tesla,fsd-clock-cmu
> +

Nitpick: Drop the white-spaces between if-then. It's easier to spot the
if-blocks if they are together.

> + then:
> + properties:
> + clocks:
> + items:
> + - description: External reference clock (24 MHz)
> +

Drop this whitespace as well.

Rest looks good to me, except the discussion about the compatible.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-01-13 13:41    [W:0.329 / U:0.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site