Messages in this thread | | | Date | Thu, 13 Jan 2022 00:10:35 +0300 | Subject | Re: [PATCH 2/3] arm64: dts: renesas: r8a77961: Add lvds0 device node | From | Nikita Yushchenko <> |
| |
>>>> + port@1 { >>>> + reg = <1>; >>>> + lvds0_out: endpoint { >>>> }; >>> >>> Endpoints must have a remote-endpoint property. Let's drop the endpoint >>> here and keep the port only, the endpoint can be declared in board >>> files. >>> >>> If you're fine with this change I can make it when applying the patch. >> >> This empty endpoint is currently defined in dtsi files for other r-car >> gen3 SoCs. >> >> Goal here is to define lvds0_out label that is then used in extension >> board dtsi files to link to the port. >> >> In this patch I just used the same approach as in files laying nearby. >> >> If this approach is not appropriate, then perhaps need to fix it in >> files for all SoCs, to make it possible for extension board dtsi to be >> compatible with all of them. > > I'm writing a patch to drop those right now :-) I'll CC you.
This is not the only place where rcag-gen3 dtsi files are using empty-endpoint pattern.
du rgb port is defined in the same way.
And, I've submitted a patch some weeks ago [1] that hooked into that.
[1] https://lore.kernel.org/lkml/20211225115308.2152364-1-nikita.yoush@cogentembedded.com/
Since there was no reply, I am about to resubmit it. But, perhaps need to do something with empty-endpoint pattern first?
Nikita
| |