Messages in this thread | | | From | Stephen Boyd <> | Date | Wed, 12 Jan 2022 12:47:15 -0800 | Subject | Re: [PATCH v19 5/5] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub |
| |
Quoting Matthias Kaehlcke (2022-01-12 11:10:48) > Add nodes for the onboard USB hub on trogdor devices. Remove the > 'always-on' property from the hub regulator, since the regulator > is now managed by the onboard_usb_hub driver. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > ---
One question below
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> > .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 19 ++++++++----------- > .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 12 +++++------- > .../dts/qcom/sc7180-trogdor-pompom-r1.dts | 11 ++++------- > .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 19 ++++++++----------- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 19 ++++++++++++++++++- > 5 files changed, 43 insertions(+), 37 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index d4f4441179fc..cd31460b3bd6 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -202,7 +202,6 @@ pp3300_hub: pp3300-hub { > pinctrl-names = "default"; > pinctrl-0 = <&en_pp3300_hub>; > > - regulator-always-on; > regulator-boot-on;
Is regulator-boot-on necessary?
> > vin-supply = <&pp3300_a>;
| |