lkml.org 
[lkml]   [2022]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v4 20/66] mm/khugepaged: Optimize collapse_pte_mapped_thp() by using vma_lookup()
    From
    On 12/1/21 15:29, Liam Howlett wrote:
    > From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
    >
    > vma_lookup() will walk the vma tree once and not continue to look for
    > the next vma. Since the exact vma is checked below, this is a more
    > optimal way of searching.
    >
    > Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>

    Reviewed-by: Vlastimil Babka <vbabka@suse.cz>

    > ---
    > mm/khugepaged.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/mm/khugepaged.c b/mm/khugepaged.c
    > index e99101162f1a..0ff7d72cdd1d 100644
    > --- a/mm/khugepaged.c
    > +++ b/mm/khugepaged.c
    > @@ -1433,7 +1433,7 @@ static int khugepaged_add_pte_mapped_thp(struct mm_struct *mm,
    > void collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr)
    > {
    > unsigned long haddr = addr & HPAGE_PMD_MASK;
    > - struct vm_area_struct *vma = find_vma(mm, haddr);
    > + struct vm_area_struct *vma = vma_lookup(mm, haddr);
    > struct page *hpage;
    > pte_t *start_pte, *pte;
    > pmd_t *pmd, _pmd;

    \
     
     \ /
      Last update: 2022-01-12 17:43    [W:4.101 / U:1.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site