Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 12 Jan 2022 17:55:35 +0200 | Subject | Re: [PATCH v2 0/3] Enable named interrupt smbus-alert for ACPI |
| |
On Wed, Jan 12, 2022 at 4:14 PM Akhil R <akhilrajeev@nvidia.com> wrote: > > I2C - SMBus core drivers use named interrupts to support smbus_alert. > As named interrupts are not available for ACPI based systems, it was > required to change the i2c bus controller driver if to use smbus alert. > These patches provide option for named interrupts in ACPI and make the > implementation similar to DT. This will enable use of interrupt named > 'smbus-alert' in ACPI as well which will be taken during i2c adapter > register.
Most of my comments are regarding spelling and documentation. The code looks almost good enough. That said, if maintainers will be okay, I'm sure the next version will be upstream-ready.
Thanks!
-- With Best Regards, Andy Shevchenko
| |