Messages in this thread | | | Subject | Re: spi: stm32-qspi: Update spi registering | From | Patrice CHOTARD <> | Date | Wed, 12 Jan 2022 14:18:01 +0100 |
| |
Hi Mark
On 1/6/22 2:51 PM, Mark Brown wrote: > On Thu, Jan 06, 2022 at 02:20:52PM +0100, patrice.chotard@foss.st.com wrote: >> From: Patrice Chotard <patrice.chotard@foss.st.com> >> >> Replace devm_spi_register_master() by spi_register_master() to ensure >> that spi sub-nodes are unregistered in the correct order when qspi driver >> is removed. > > This commit message doesn't describe the actual issue. The change is > fixing ordering within the driver itself - the driver is freeing things > in the remove() callback which are used by the controller but thanks to > the use of devm the controller isn't unregistered from the core until > after the remove() callback has run so we might still have something > running. "Subnodes" aren't an issue here.
OK i will update this comment to be clearer.
> > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. >
Agree, i forgot to use the correct script to submit patches to ML.
Thanks Patrice
| |